Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "tune default params (#2100)" and add Go module #2111

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Jul 5, 2023

This reverts commit a46ac9e.

Description:

Related Issue:

Versions:

  • Go Version: 1.20.5
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.27.3
  • NGT Version: 2.0.13

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 5, 2023

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (a6d8701) 30.65% compared to head (2729c1b) 30.63%.

❗ Current head 2729c1b differs from pull request most recent head 38d60ab. Consider uploading reports for the commit 38d60ab to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2111      +/-   ##
==========================================
- Coverage   30.65%   30.63%   -0.03%     
==========================================
  Files         347      347              
  Lines       34255    34255              
==========================================
- Hits        10501    10494       -7     
- Misses      23276    23283       +7     
  Partials      478      478              
Impacted Files Coverage Δ
pkg/gateway/lb/handler/grpc/aggregation.go 0.00% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

hlts2
hlts2 previously approved these changes Jul 5, 2023
@kpango kpango changed the title Revert "tune default params (#2100)" Revert "tune default params (#2100)" and add Go module Jul 5, 2023
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 6, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 197df6f
Status:⚡️  Build in progress...

View logs

@kpango kpango force-pushed the revert2/pr2100/add-go-module branch from a03e072 to 784807f Compare July 6, 2023 16:45
@kpango kpango force-pushed the revert2/pr2100/add-go-module branch 4 times, most recently from dd73e4a to 1359dcf Compare July 6, 2023 18:22
@kpango kpango force-pushed the revert2/pr2100/add-go-module branch from 1359dcf to 2729c1b Compare July 6, 2023 19:04
@kpango kpango force-pushed the revert2/pr2100/add-go-module branch from 2729c1b to 38d60ab Compare July 6, 2023 19:09
@vankichi vankichi closed this Jul 11, 2023
@vankichi vankichi reopened this Jul 11, 2023
@kpango kpango merged commit 9774624 into main Jul 11, 2023
@kpango kpango deleted the revert2/pr2100/add-go-module branch July 11, 2023 08:04
@hlts2 hlts2 mentioned this pull request Sep 13, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants